[
https://issues.apache.org/jira/browse/CALCITE-3535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985940#comment-16985940
]
Ruben Q L edited comment on CALCITE-3535 at 12/2/19 10:13 AM:
--------------------------------------------------------------
It seems that the proposed [PR|https://github.com/apache/calcite/pull/1616]
somehow makes the tests get stuck (in some environments). Travis build was
executed successfully, but Github CI checks were still running the tests after
1h (and I had to manually cancel them). Also AppVeyor timed out.
I have been able to reproduce it in my local environment [1], it seems that
UtilTest (UtilTest#testRelBuilderExample) gets stuck when running {{gradlew
test}} or {{gradlew :core:test}} (see attached thread dump). However, when
running that test individually in IntelliJ (2019.2.4 community edition), it
runs ok.
I will continue investigating...
[1]
{code}
gradlew --version
------------------------------------------------------------
Gradle 6.0.1
------------------------------------------------------------
Build time: 2019-11-18 20:25:01 UTC
Revision: fad121066a68c4701acd362daf4287a7c309a0f5
Kotlin: 1.3.50
Groovy: 2.5.8
Ant: Apache Ant(TM) version 1.10.7 compiled on September 1 2019
JVM: 1.8.0_212 (Oracle Corporation 25.212-b10)
OS: Windows 10 10.0 amd64
{code}
was (Author: rubenql):
It seems that the proposed [PR|https://github.com/apache/calcite/pull/1616]
somehow makes the tests get stuck (in some environments). Travis build was
executed successfully, but Github CI checks were still running the tests after
1h (and I had to manually cancel them). Also AppVeyor timed out.
I have been able to reproduce it in my local environment [1], it seems that
UtilTest gets stuck when launching {{gradlew test}} or {{gradlew :core:test}}
(see attached thread dump). However, when running that test individually in
IntelliJ (2019.2.4 community edition), it runs ok.
I will continue investigating...
[1]
{code}
gradlew --version
------------------------------------------------------------
Gradle 6.0.1
------------------------------------------------------------
Build time: 2019-11-18 20:25:01 UTC
Revision: fad121066a68c4701acd362daf4287a7c309a0f5
Kotlin: 1.3.50
Groovy: 2.5.8
Ant: Apache Ant(TM) version 1.10.7 compiled on September 1 2019
JVM: 1.8.0_212 (Oracle Corporation 25.212-b10)
OS: Windows 10 10.0 amd64
{code}
> EnumerableJoinRule: remove unnecessary Filter on top of INNER Join
> ------------------------------------------------------------------
>
> Key: CALCITE-3535
> URL: https://issues.apache.org/jira/browse/CALCITE-3535
> Project: Calcite
> Issue Type: Task
> Components: core
> Affects Versions: 1.21.0
> Reporter: Ruben Q L
> Assignee: Ruben Q L
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.22.0
>
> Attachments: threadDump.txt
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With the implementation of CALCITE-2973, now EnumerableHashJoin supports all
> type of conditions (not just equi joins). However, there is still one
> [TODO|https://github.com/apache/calcite/blob/07c1efbb2b42a0e27f9d01968d357d9c1e17cd51/core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableJoinRule.java#L89]
> in EnumerableHashJoinRule that, in case of an INNER Join, creates a Filter
> with the non-equi conditions on top of the EnumerableHashJoin (created only
> with the equi-conditions), this filter is not really needed, since now
> EnumerableHashJoinRule can support the full condition: equi and non-equi
> items.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
