[
https://issues.apache.org/jira/browse/CALCITE-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987207#comment-16987207
]
Julian Hyde commented on CALCITE-3559:
--------------------------------------
Please don't commit this until we get to consensus. This is a step backwards.
HydromaticFileSetCheck is not perfect, but it checks quite a few things that
checkstyle cannot. I wrote it because checkstyle is not easily extensible
either.
> Drop HydromaticFileSetCheck from Checkstyle configuration
> ---------------------------------------------------------
>
> Key: CALCITE-3559
> URL: https://issues.apache.org/jira/browse/CALCITE-3559
> Project: Calcite
> Issue Type: Task
> Components: build
> Affects Versions: 1.21.0
> Environment: HydromaticFileSetCheck is not customizable, and it is
> not supported.
> HydromaticFileSetCheck is not compatible with Checkstyle 8.x which resolves
> concurrency issues.
> Lots of checks implemented in HydromaticFileSetCheck can be automated (==the
> software could automatically fix the code rather than complain).
> So we should drop HydromaticFileSetCheck
> Reporter: Vladimir Sitnikov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
