[ https://issues.apache.org/jira/browse/CALCITE-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16996072#comment-16996072 ]
Julian Hyde commented on CALCITE-3587: -------------------------------------- I see now that {{clean}} does not throw when given a Java {{float}} value for a SQL {{DECIMAL}} literal. Do we think that it should? I am inclined to say yes. > RexBuilder may lose decimal fraction for creating literal with DECIMAL type > --------------------------------------------------------------------------- > > Key: CALCITE-3587 > URL: https://issues.apache.org/jira/browse/CALCITE-3587 > Project: Calcite > Issue Type: Bug > Reporter: Wang Yanlin > Assignee: Wang Yanlin > Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > this test > {code:java} > // RexBuilderTest > @Test public void testDecimal() { > final RelDataTypeFactory typeFactory = > new SqlTypeFactoryImpl(RelDataTypeSystem.DEFAULT); > final RelDataType type = typeFactory.createSqlType(SqlTypeName.DECIMAL, 4, 2); > final RexBuilder builder = new RexBuilder(typeFactory); > final RexLiteral literal = (RexLiteral) builder.makeLiteral(12.3, type, > false); > Comparable value = literal.getValue(); > assertThat(value.toString(), is("12.3")); > } > {code} > fails with message > {code:java} > java.lang.AssertionError: > Expected: is "12.3" > but: was "12" > Expected :12.3 > Actual :12 > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)