[
https://issues.apache.org/jira/browse/CALCITE-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006989#comment-17006989
]
Rui Wang commented on CALCITE-3663:
-----------------------------------
Thanks [~dhirenda.gautam]
I will help take a look at your PR soon.
> Support for TRIM function in Bigquery dialect
> ---------------------------------------------
>
> Key: CALCITE-3663
> URL: https://issues.apache.org/jira/browse/CALCITE-3663
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Dhirenda Gautam
> Priority: Major
>
> In current Calcite implementation for query : SELECT TRIM('ABC') for
> big-query Dialect it translated into SELECT TRIM(BOTH ' ' FROM 'ABC') .
> But the appropriate query for BigQuery is :: SELECT TRIM('ABC')
> Similarly below query
> SELECT TRIM(BOTH 'a' from 'ABC')
> SELECT TRIM(LEADING ' ' from 'ABC')
> SELECT TRIM(TRAILING ' ' from 'ABC') are translated into invalid BigQuery
> query.
> Unparse logic for the trim has been handle in BigQuery dialect to convert the
> source Trim query into valid bigQuery query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
