[ 
https://issues.apache.org/jira/browse/CALCITE-3681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009154#comment-17009154
 ] 

Vladimir Sitnikov commented on CALCITE-3681:
--------------------------------------------

Note: the fix can be found in 
https://github.com/apache/calcite/pull/1702/commits (see [CALCITE-3681] Refine 
RelMdColumnUniquenes commit)

{quote}There are problems with RelMdRowCount too,{quote}

I have fixed it as well.

All those metadata/cost/... can't be tested in isolation, so "overall patch 
queue" can be found in PR#1702. Hopefully, some changes could be extracted and 
merged individually, however, I would prefer to see workable solution in 
PR#1702, and only then extract relevant bits to master.

{quote} Also review how RelMdMinRowCount{quote}
Is MinRowCount used at all? I thought it was not that useful, so I skipped it 
for now.


> Refine RelMdColumnUniqueness and RelMdRowCount for Aggregate
> ------------------------------------------------------------
>
>                 Key: CALCITE-3681
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3681
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.21.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Vladimir Sitnikov
>            Priority: Major
>
> Aggregate might have grouping sets, so 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to