[ 
https://issues.apache.org/jira/browse/CALCITE-3714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009296#comment-17009296
 ] 

Julian Hyde commented on CALCITE-3714:
--------------------------------------

I was mistaken. {{SqlLiteral.createBinaryString}} is only called from tests. 
Probably because literals like {{B'10010101'}} are no longer allowed in SQL. 
Still, it's just as easy to fix it & add a test as to remove it.

> BitString.createFromBytes reverses order of the bits in each byte
> -----------------------------------------------------------------
>
>                 Key: CALCITE-3714
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3714
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Andrew Pilloud
>            Priority: Trivial
>
> BitString.createFromBytes reverses the order of the bits in each byte. 
> (Passing in 'a' I expect 01100001 but get 10000110.)
> BitString.createFromHexString works as expected, and appears to be the one 
> everyone is using. The "fix" might be to just delete the broken method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to