[
https://issues.apache.org/jira/browse/CALCITE-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Chen resolved CALCITE-3723.
---------------------------------
Fix Version/s: 1.22.0
Assignee: Danny Chen
Resolution: Fixed
Fixed in
[5cfd8c3|https://github.com/apache/calcite/commit/5cfd8c31cea1bf5411e503b15714cab5fc1c0d0a]
!
> Following the change to add hints to RelNode, deprecate the old constructors
> ----------------------------------------------------------------------------
>
> Key: CALCITE-3723
> URL: https://issues.apache.org/jira/browse/CALCITE-3723
> Project: Calcite
> Issue Type: Sub-task
> Reporter: Julian Hyde
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.22.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In CALCITE-482 and CALCITE-3590 we added constructors for various sub-classes
> RelNode ({{LogicalProject}}, {{LogicalAggregate}}, and others) that take a
> list of hints. But now those classes have two constructors. Our practice has
> been to have only one (public, non-deprecated) constructor in each RelNode
> class. (Otherwise we would have dozens.) So, please deprecate the old
> constructors and change code that uses them.
> Can we do this before 1.22?
> Also note that the new and old constructors have exactly the same comment.
> You should avoid that. But in this case, just remove the comment of the
> deprecated constructor.
> The non-hints constructor does {{new ArrayList<>()}}. Please change to use
> {{ImmutableList.of()}}, which saves a malloc.
> cc [~danny0405] and [~icshuo].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
