[
https://issues.apache.org/jira/browse/CALCITE-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014774#comment-17014774
]
Danny Chen commented on CALCITE-3730:
-------------------------------------
All the "hints" arguments are added as optional, so the existing code except to
be not affected, but i agree, if we put the "hints" with other arguments,
people would very probably pass an empty collection there; also the hints
should be a common attribute for all the "Hintable"s, so i agree with your idea.
There is only one exception, for the RelBuilder#project, i have to pass the
hints explicitly because it is a recursion internal, when do the projection
merge, i have to pass along the hints of the inner projection.
> Add hints to RelBuilder
> -----------------------
>
> Key: CALCITE-3730
> URL: https://issues.apache.org/jira/browse/CALCITE-3730
> Project: Calcite
> Issue Type: Sub-task
> Components: core
> Affects Versions: 1.22.0
> Reporter: Danny Chen
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.22.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
