[ 
https://issues.apache.org/jira/browse/CALCITE-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036042#comment-17036042
 ] 

Julian Hyde commented on CALCITE-3794:
--------------------------------------

Can you improve the summary? Who should ‘return directly’?

> Return directly if there is no pulled up predicate
> --------------------------------------------------
>
>                 Key: CALCITE-3794
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3794
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.21.0
>            Reporter: Chunwei Lei
>            Assignee: Chunwei Lei
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.22.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> If there is no pulled up predicates, it can not simplify anything in 
> {{simplifyUsingPredicates}}[1]. So it'd better return directly to reduce 
> overhead.
> [1][https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rex/RexSimplify.java#L1572-L1586]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to