[
https://issues.apache.org/jira/browse/CALCITE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Chen resolved CALCITE-3807.
---------------------------------
Assignee: Danny Chen
Resolution: Fixed
Fixed in
[e1e5898|https://github.com/apache/calcite/commit/e1e5898f8975f2478862973c19799c8be45b8d83]
!
> checkForSatisfiedConverters() is unnecessary
> ---------------------------------------------
>
> Key: CALCITE-3807
> URL: https://issues.apache.org/jira/browse/CALCITE-3807
> Project: Calcite
> Issue Type: Bug
> Reporter: Xiening Dai
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.22.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When VolcanoPlanner registers an abstract converter, it adds the converter
> into set.abstractConverters list, then calls checkSatisfiedConverter() to see
> if any converter is satisfied and can be remove from the list. But for every
> abstract converter, it always satisfies itself (changeTraitsUsingConverters()
> returns itself). Basically the converter would be removed from the list right
> after it's added. So this check is completely unnecessary and it slows down
> the planner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
