[
https://issues.apache.org/jira/browse/CALCITE-3821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044962#comment-17044962
]
Xiening Dai commented on CALCITE-3821:
--------------------------------------
* I should have update the comments. Sorry, will do in next iteration.
* Constant B is also removed along with this change.
* I traced back to a commit back in 2014 -
66cfb120f [CALCITE-544] Implement Union in Interpreter; [CALCITE-562] Implement
inner JOIN in interpreter and improve handling of scalar expressions
It's pretty old code and the constant has been there since then. I don't think
it has any effect and it should be safe to remove.
> RelOptUtil::containsMultisetOrWindowedAgg doesn't really check multiset
> -----------------------------------------------------------------------
>
> Key: CALCITE-3821
> URL: https://issues.apache.org/jira/browse/CALCITE-3821
> Project: Calcite
> Issue Type: Bug
> Reporter: Xiening Dai
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The check of containsMultiset() is shortcut by a "false" constant. Also what
> the function really does is to check rel node does *not* contain window aggs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
