[
https://issues.apache.org/jira/browse/CALCITE-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055333#comment-17055333
]
Julian Hyde commented on CALCITE-3840:
--------------------------------------
The fix for 3840 looks good. Go ahead and commit.
Not so sure about the fix for CALCITE-3810 in the same PR. Probably better to
do the rewrite in the RelNode domain rather than SqlNode domain. Rewriting SQL
ASTs (even ones we have just generated) is too fragile.
> Re-aliasing of VALUES that has column aliases produces wrong SQL in the JDBC
> adapter
> ------------------------------------------------------------------------------------
>
> Key: CALCITE-3840
> URL: https://issues.apache.org/jira/browse/CALCITE-3840
> Project: Calcite
> Issue Type: Bug
> Components: jdbc-adapter
> Affects Versions: 1.21.0
> Reporter: Christian Beikov
> Priority: Major
>
> Rendering a VALUES relnode to e.g. PostgreSQL will produce \{{FROM
> (VALUES((1))) AS t(col_alias)}} where "t" is a static alias. When e.g.
> joining with such a VALUES, the RelToSqlConverter tries to re-alias this with
> a unique alias, but fails because it produces \{{FROM (VALUES((1))) AS
> t(col_alias) AS newAlias}}.
> The fix is to replace the static table alias instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
