[
https://issues.apache.org/jira/browse/CALCITE-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061200#comment-17061200
]
Julian Hyde edited comment on CALCITE-3726 at 3/17/20, 9:45 PM:
----------------------------------------------------------------
Can you improve the summary and description? It's not very clear what this
feature provides.
This adds CREATE TYPE. Need an update to reference.md.
Reviewers, you must check the quality of the commit message and documentation,
not just the code. As I have said many times, if you can describe a feature
using SQL, you should do so; following that advice, this case is a slam dunk:
"Implement CREATE TYPE and DROP TYPE".
If this is complete, why is a sub-task still open?
was (Author: julianhyde):
Can you improve the summary and description? It's not very clear what this
feature provides.
If this is complete, why is a sub-task still open?
> Allow declaring type objects
> ----------------------------
>
> Key: CALCITE-3726
> URL: https://issues.apache.org/jira/browse/CALCITE-3726
> Project: Calcite
> Issue Type: New Feature
> Reporter: Ritesh
> Assignee: Ritesh
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.23.0
>
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> [https://docs.oracle.com/cd/B19306_01/appdev.102/b14261/objects.htm#i7530]
> e.g. :
>
> {code:java}
> employee_typ(315, 'Francis', 'Logan', 'FLOGAN',
> '555.777.2222', '01-MAY-04', 'SA_MAN', 11000, .15, 101, 110,
> address_typ('376 Mission', 'San Francisco', 'CA', '94222'))
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
