[ 
https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062341#comment-17062341
 ] 

Stamatis Zampetakis commented on CALCITE-2970:
----------------------------------------------

Nice idea [~hyuan]!! I didn't thoroughly thought about all use-cases but high 
level I really like the approach that you took in 
[PR#1860|https://github.com/apache/calcite/pull/1860]. For a long time, I was 
debating with my self to understand if RelSubset should model "derived" or 
"required" traits but I didn't think that it could do both :)

> Performance issue when enabling abstract converter for EnumerableConvention
> ---------------------------------------------------------------------------
>
>                 Key: CALCITE-2970
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2970
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> If we enable the use of abstract converter for {{EnumerableConvention}}, by 
> making {{useAbstractConvertersForConversion}} return true, 
> {{JDBCTest.testJoinManyWay}} will not complete.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to