[
https://issues.apache.org/jira/browse/CALCITE-3871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079016#comment-17079016
]
Vladimir Sitnikov commented on CALCITE-3871:
--------------------------------------------
[~danny0405], AFAIK your only concerns were
a) apiguardian was used just in a couple of places
b) you didn't know if the apiguardian is a publicly accepted API or not
c) "it's really weird from Flink side, why we have to introduce an additional
jar that we never uses"
All your concerns were addressed.
Just in case:
a) we should use apiguardian more to clarify the intended consumers of the API
(e.g. public vs internal)
b) bnd tool has apiguardian integration
c) calcite-core already has 30+ runtime dependencies (over 13MiB), so adding
2KiB apiguardian does not hurt at all
On top of that,
https://github.com/apache/calcite/commit/ebbba566fbdbdd0923adda596467090d708cc14b
adds licensing issue. Are you sure the code is indeed "Licensed to the Apache
Software Foundation"?
The original copyright header was different, and you must keep it to adhere to
the terms of Apache-2.0.
So, I'll restore apiguardian as a dependency unless you provide clarification
within 72 hours.
> Remove dependency of org.apiguardian:apiguardian-api
> ----------------------------------------------------
>
> Key: CALCITE-3871
> URL: https://issues.apache.org/jira/browse/CALCITE-3871
> Project: Calcite
> Issue Type: Improvement
> Components: core, linq4j
> Affects Versions: 1.22.0
> Reporter: Danny Chen
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The org.apiguardian:apiguardian-api is introduced in CALCITE-3652 in order to
> mark the new introduced API status.
> Remove the dependency and copy the class into Calcite because the
> org.apiguardian:apiguardian-api jar has only a single API.java class and it
> is not necessary to add a dependency for that(All the downstream projects
> that have calcite-core as a dependency would see this jar which is annoying).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
