[ 
https://issues.apache.org/jira/browse/CALCITE-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17080153#comment-17080153
 ] 

Danny Chen commented on CALCITE-3900:
-------------------------------------

Renamed SqlValidator.getConfig() to config(). The SqlValidatorImpl has many 
sub-classes, it we make the config final, every sub-class would have to 
re-implement the #transform which is error-prone.

I marked the #transform an internal API and i would make the config final 
before 1.24.

> Add Config for SqlValidator
> ---------------------------
>
>                 Key: CALCITE-3900
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3900
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.22.0
>            Reporter: Danny Chen
>            Assignee: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.23.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The SqlValidator now has 7 setXXX methods to all kinds of control flags, 
> which is hard for code evolving.
> There is also no way to config these things through the FrameworkConfig.
> Add a SqlValidator.Config to solve these problems.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to