[
https://issues.apache.org/jira/browse/CALCITE-3931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085358#comment-17085358
]
Danny Chen edited comment on CALCITE-3931 at 4/17/20, 2:39 AM:
---------------------------------------------------------------
{quote}Lastly, I believe lookahead should be before the first item of a list,
not before every item. {quote}
Oops, i can not put the LOOKAHEAD before the loop because JavaCC thinks that is
not a condition block.
was (Author: danny0405):
{quote}Lastly, I believe lookahead should be before the first item of a list,
not before every item. {quote}
Makes sense, would fix soon ~
> Add LOOKAHEAD(2) for methods defined in createStatementParserMethods
> --------------------------------------------------------------------
>
> Key: CALCITE-3931
> URL: https://issues.apache.org/jira/browse/CALCITE-3931
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.22.0
> Reporter: Danny Chen
> Assignee: Danny Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.23.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The default LOOKAHEAD is 1 which is very probably to conflict, especially for
> custom parse block like SqlCreate.
>
> Sets the LOOKAHEAD(2) to reduce conflict.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
