[
https://issues.apache.org/jira/browse/CALCITE-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104108#comment-17104108
]
Julian Hyde commented on CALCITE-3679:
--------------------------------------
Sorry my comments seemed harsh. Like you, I am a volunteer in this project, and
have limited time to spend on each case that I review, so I'm sometimes not as
diplomatic as I should be.
Please don't be put off by my criticism. Re-reading what I wrote, most of it is
constructive, and most of it is fair:
* Yes, you did copy-paste comments without changing the text. As I said, it was
my "first impression" but it was not incorrect.
* Yes, a bug does need a description. Especially when your only description is
a link to a web page. (Which may change or disappear in future.) That web page
has 7 functions and you only seem to have implemented 1. Implementing just one
is fine, if you say you are implementing one.
* No, don't go tell me to read the PR to figure out the scope. You're just
saying "it is what it is", which is not helpful. The scope needs to be
described in the JIRA case.
* I still believe that we need to get the type system sorted out early - i.e.
in this PR.
We should definitely have a conversation about what is "minimum viable
product". Maybe this feature should be marked "experimental". I don't want to
add major new features to Calcite, such as this, and then have to modify them
in future releases.
My review comments did not acknowledge the considerable amount of work you have
done, and that was wrong. I should have acknowledged that.
Also note that I was grumbling about the lambda implementations in Presto and
Spark - not about your work. I have put considerable thought into lambdas in
SQL - see my personal [Morel project|https://github.com/julianhyde/morel/] - so
there is a good chance that we can do a better job than Presto or Spark did.
I also think that we can get this PR to a state where it can be committed. But
realistically, 1.23 is too soon. It will take a few iterations.
> Allow lambda expressions in SQL queries
> ---------------------------------------
>
> Key: CALCITE-3679
> URL: https://issues.apache.org/jira/browse/CALCITE-3679
> Project: Calcite
> Issue Type: New Feature
> Reporter: Ritesh
> Assignee: Ritesh
> Priority: Major
> Labels: pull-request-available
> Attachments: [CALCITE-3679]_Basic_implementation.patch
>
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> [https://teradata.github.io/presto/docs/0.167-t/functions/lambda.html]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
