[jira] [Commented] (CALCITE-4001) Should support dialect when unparsing SqlDataTypeSpec

[Wang Yanlin (Jira)]

    [ 
https://issues.apache.org/jira/browse/CALCITE-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107108#comment-17107108
 ] 

Wang Yanlin commented on CALCITE-4001:
--------------------------------------

May be add 
{noformat}
public void unparseType(SqlWriter writer, RelDataType dataType, int leftPrec, 
int rightPrec)
{noformat}
in sql dialect.

> Should support dialect when unparsing SqlDataTypeSpec
> -----------------------------------------------------
>
>                 Key: CALCITE-4001
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4001
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Xurenhe
>            Priority: Minor
>
> SqlBasicTypeNameSpec cannot cover all data types of other sql's engine, when 
> doing SqlNode To SqlString,
> such as cast(id as bigint), but some sql-engine only support cast(id as long).
> I think there should be based on dialect, just like 
> org.apache.calcite.sql.SqlDialect#unparseOffsetFetch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)