[ 
https://issues.apache.org/jira/browse/CALCITE-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112660#comment-17112660
 ] 

Rui Wang commented on CALCITE-4011:
-----------------------------------

Thanks for your patient and detailed explanation. Now I can that it is 
"EnumerableConvention.enforce" that will create the EnumerableSort (enforce 
traits, of course).


I have updated https://github.com/apache/calcite/pull/1985 to demonstrate 
traits pass down in EnumerableProject and EnumerableFilter. Please take a look.

I didn't implement traits derivation. (cause I didn't find an example from 
#1953). Please let me know if you think the traits derivation should be include 
in the same pull request.

> Implement trait propagation for EnumerableProject and EnumerableFilter
> ----------------------------------------------------------------------
>
>                 Key: CALCITE-4011
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4011
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Haisheng Yuan
>            Assignee: Rui Wang
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> So that parent trait can be passed down, and it can derive new traitsets from 
> child. Most importantly, as a demonstration. So that SortProjectTransposeRule 
> and ProjectSortTransposeRule can be disabled when topDownOpt is enabled.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to