[
https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149346#comment-17149346
]
TANG Wen-hui edited comment on CALCITE-4079 at 7/1/20, 11:51 AM:
-----------------------------------------------------------------
Hello [~zabetak] [~julianhyde]
I created my own parser depend on the Parser.jj template, and I have two tests
for the new parser which are PivotParserTest and PivotRelToSqlTest.
When I try to do "mvn test", the test process was blocked.
>From the below details, I found the test blocked in two places where
>CalciteSqlDialect.DEFAULT and AnsiSqlDialect.DEFAULT was used.
The CalciteSqlDialect.DEFAULT are used in PivotRelToSqlTest, PivotParserTest
extends the SqlParserTest and use the SqlNode#toSqlString which is related with
AnsiSqlDialect.DEFAULT.
!image-2020-07-01-19-27-25-354.png!
!image-2020-07-01-19-51-32-397.png!
was (Author: winipanda):
Hello [~zabetak] [~julianhyde]
I created my own parser depend on the Parser.jj template, and I have two tests
for the new parser which are PivotParserTest and PivotRelToSqlTest.
When I try to do "mvn test", the test process was blocked.
>From the below details, I found the test blocked in two places where
>CalciteSqlDialect.DEFAULT and AnsiSqlDialect.DEFAULT was used.
The CalciteSqlDialect.DEFAULT are used in PivotRelToSqlTest, PivotParserTest
extends the SqlParserTest and use the SqlNode#toSqlString which is related with
AnsiSqlDialect.DEFAULT.
!image-2020-07-01-19-27-25-354.png!
!image-2020-07-01-19-27-31-913.png!
> Remove the deprecated code from SqlDialect
> ------------------------------------------
>
> Key: CALCITE-4079
> URL: https://issues.apache.org/jira/browse/CALCITE-4079
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.23.0
> Reporter: TANG Wen-hui
> Priority: Major
> Attachments: image-2020-07-01-19-19-35-015.png,
> image-2020-07-01-19-20-27-918.png, image-2020-07-01-19-27-25-354.png,
> image-2020-07-01-19-51-32-397.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code:java}
> /** @deprecated Use {@link AnsiSqlDialect#DEFAULT} instead. */
> @Deprecated // to be removed before 2.0
> public static final SqlDialect DUMMY =
> AnsiSqlDialect.DEFAULT;
> /** @deprecated Use {@link CalciteSqlDialect#DEFAULT} instead. */
> @Deprecated // to be removed before 2.0
> public static final SqlDialect CALCITE =
> CalciteSqlDialect.DEFAULT;{code}
> SqlDialect#DUMMY and SqlDialect#CALCITE are marked deprecated and have not be
> used in any places.
> It would be better to remove them to avoid class initialization deadlock.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
