[
https://issues.apache.org/jira/browse/CALCITE-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146615#comment-17146615
]
Julian Hyde edited comment on CALCITE-4088 at 7/17/20, 11:03 PM:
-----------------------------------------------------------------
In CALCITE-3176 we added JSON support to the demo adapter, and then made the
file adapter depend on the demo adapter.
In my opinion, that a mistake. Going forward, we should only add new
functionality to the file adapter. The demo adapter should never support
JSON-lines format.
We should also refactor, moving the JSON-related classes from
https://github.com/apache/calcite/tree/master/example/csv/src/main/java/org/apache/calcite/adapter/csv
to
https://github.com/apache/calcite/tree/master/file/src/main/java/org/apache/calcite/adapter/file.
So the demo adapter will depend on the file adapter, not vice versa. I have
logged I have logged CALCITE-4128 for this task.
was (Author: julianhyde):
In CALCITE-3176 we added JSON support to the demo adapter, and then made the
file adapter depend on the demo adapter.
In my opinion, that a mistake. Going forward, we should only add new
functionality to the file adapter. The demo adapter should never support
JSON-lines format.
We should also refactor, moving the JSON-related classes from
https://github.com/apache/calcite/tree/master/example/csv/src/main/java/org/apache/calcite/adapter/csv
to
https://github.com/apache/calcite/tree/master/file/src/main/java/org/apache/calcite/adapter/file.
So the demo adapter will depend on the file adapter, not vice versa.
> Demo CSV adapter should include support for JSON lines files
> ------------------------------------------------------------
>
> Key: CALCITE-4088
> URL: https://issues.apache.org/jira/browse/CALCITE-4088
> Project: Calcite
> Issue Type: New Feature
> Components: csv-adapter
> Reporter: James Anderson
> Assignee: James Anderson
> Priority: Minor
>
> The demo CSV adapter includes support for parsing "traditionally" formatted
> JSON documents, but it would also be very helpful to support reading files
> formatted as "jsonlines". See [http://jsonlines.org/]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
