[
https://issues.apache.org/jira/browse/CALCITE-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165183#comment-17165183
]
Ruben Q L commented on CALCITE-4079:
------------------------------------
[~julianhyde], I have tested
https://github.com/julianhyde/calcite/tree/3923-rule-config on my Calcite-based
application, everything works fine, no signs of NPE or class-loading issues.
I have a minor request though, I saw that you removed all {{getChildExps}}
methods from the operators (which is fine, since it was deprecated). However,
this makes it impossible to access {{Sort}}'s {{fieldExps}}, which can be
useful in some situations. Do you think it could be possible to add a new
equivalent method for that? e.g. something like:
{code}
public abstract class Sort extends SingleRel {
...
public List<RexNode> getFieldExps() {
return fieldExps;
}
...
{code}
> Dialect constants in SqlDialect can cause class initialization deadlock
> -----------------------------------------------------------------------
>
> Key: CALCITE-4079
> URL: https://issues.apache.org/jira/browse/CALCITE-4079
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.23.0
> Reporter: TANG Wen-hui
> Assignee: Julian Hyde
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.25.0
>
> Attachments: CALCITE-4079.01.patch,
> image-2020-07-01-19-27-25-354.png, image-2020-07-01-19-51-32-397.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code:java}
> /** @deprecated Use {@link AnsiSqlDialect#DEFAULT} instead. */
> @Deprecated // to be removed before 2.0
> public static final SqlDialect DUMMY =
> AnsiSqlDialect.DEFAULT;
> /** @deprecated Use {@link CalciteSqlDialect#DEFAULT} instead. */
> @Deprecated // to be removed before 2.0
> public static final SqlDialect CALCITE =
> CalciteSqlDialect.DEFAULT;{code}
> SqlDialect#DUMMY and SqlDialect#CALCITE are marked deprecated and have not be
> used in any places.
> It would be better to remove them to avoid class initialization deadlock.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
