[
https://issues.apache.org/jira/browse/CALCITE-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anton Haidai updated CALCITE-4150:
----------------------------------
Description:
RelToSqlConverterTest:
{code:java}
@Test void testSelectNullNoCast() {
String query = "select \"product_id\", null as dummy from \"product\"";
final String expected = "SELECT \"product_id\", CAST(NULL AS NULL) AS
\"DUMMY\"\n"
+ "FROM \"foodmart\".\"product\"";
sql(query).ok(expected);
}{code}
the test works fine in 1.23.
result in 1.24:
{code:java}
Unsupported type when convertTypeToSpec: NULL
java.lang.UnsupportedOperationException: Unsupported type when
convertTypeToSpec: NULL at
org.apache.calcite.sql.type.SqlTypeUtil.convertTypeToSpec(SqlTypeUtil.java:1078)
at org.apache.calcite.sql.SqlDialect.getCastSpec(SqlDialect.java:790) at
org.apache.calcite.rel.rel2sql.RelToSqlConverter.castNullType(RelToSqlConverter.java:361)
at
org.apache.calcite.rel.rel2sql.RelToSqlConverter.visit(RelToSqlConverter.java:342)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566) at
org.apache.calcite.util.ReflectUtil$2.invoke(ReflectUtil.java:524) at
org.apache.calcite.rel.rel2sql.RelToSqlConverter.dispatch(RelToSqlConverter.java:131){code}
Please note, that there is an existing test "testSelectNull()", but it tests
nulls with a cast, "CAST(NULL AS INT)".
was:
RelToSqlConverterTest:
{code:java}
@Test void testSelectNullNoCast() {
String query = "select \"product_id\", null as dummy from \"product\"";
final String expected = "SELECT \"product_id\", CAST(NULL AS NULL) AS
\"DUMMY\"\n"
+ "FROM \"foodmart\".\"product\"";
sql(query).ok(expected);
}{code}
the test works fine in 1.23.
result in 1.24:
{code:java}
Unsupported type when convertTypeToSpec: NULL
Unsupported type when convertTypeToSpec: NULL
java.lang.UnsupportedOperationException: Unsupported type when
convertTypeToSpec: NULL at
org.apache.calcite.sql.type.SqlTypeUtil.convertTypeToSpec(SqlTypeUtil.java:1078)
at org.apache.calcite.sql.SqlDialect.getCastSpec(SqlDialect.java:790) at
org.apache.calcite.rel.rel2sql.RelToSqlConverter.castNullType(RelToSqlConverter.java:361)
at
org.apache.calcite.rel.rel2sql.RelToSqlConverter.visit(RelToSqlConverter.java:342)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566) at
org.apache.calcite.util.ReflectUtil$2.invoke(ReflectUtil.java:524) at
org.apache.calcite.rel.rel2sql.RelToSqlConverter.dispatch(RelToSqlConverter.java:131){code}
Please note, that there is an existing test "testSelectNull()", but it tests
nulls with cast, "CAST(NULL AS INT)".
> RelToSqlConverter does not support null without a cast: "Unsupported type
> when convertTypeToSpec: NULL"
> -------------------------------------------------------------------------------------------------------
>
> Key: CALCITE-4150
> URL: https://issues.apache.org/jira/browse/CALCITE-4150
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.24.0
> Reporter: Anton Haidai
> Priority: Major
>
> RelToSqlConverterTest:
> {code:java}
> @Test void testSelectNullNoCast() {
> String query = "select \"product_id\", null as dummy from \"product\"";
> final String expected = "SELECT \"product_id\", CAST(NULL AS NULL) AS
> \"DUMMY\"\n"
> + "FROM \"foodmart\".\"product\"";
> sql(query).ok(expected);
> }{code}
> the test works fine in 1.23.
> result in 1.24:
> {code:java}
> Unsupported type when convertTypeToSpec: NULL
> java.lang.UnsupportedOperationException: Unsupported type when
> convertTypeToSpec: NULL at
> org.apache.calcite.sql.type.SqlTypeUtil.convertTypeToSpec(SqlTypeUtil.java:1078)
> at org.apache.calcite.sql.SqlDialect.getCastSpec(SqlDialect.java:790) at
> org.apache.calcite.rel.rel2sql.RelToSqlConverter.castNullType(RelToSqlConverter.java:361)
> at
> org.apache.calcite.rel.rel2sql.RelToSqlConverter.visit(RelToSqlConverter.java:342)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method) at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566) at
> org.apache.calcite.util.ReflectUtil$2.invoke(ReflectUtil.java:524) at
> org.apache.calcite.rel.rel2sql.RelToSqlConverter.dispatch(RelToSqlConverter.java:131){code}
> Please note, that there is an existing test "testSelectNull()", but it tests
> nulls with a cast, "CAST(NULL AS INT)".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
