[
https://issues.apache.org/jira/browse/CALCITE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189683#comment-17189683
]
Vladimir Sitnikov commented on CALCITE-4217:
--------------------------------------------
I fail to realize why is it important that CrossType had {{getFieldList()}}
and {{getFieldNames()}} while it must throw assertion error from
{{getFieldCount()}}.
It looks like a non-sense.
Just in case, currently getFieldList and getFieldNames do already work for
CrossType. The missing piece is getFieldCount
> RelCrossType#isStruct should be true rather than false
> ------------------------------------------------------
>
> Key: CALCITE-4217
> URL: https://issues.apache.org/jira/browse/CALCITE-4217
> Project: Calcite
> Issue Type: Sub-task
> Components: core
> Affects Versions: 1.25.0
> Reporter: Vladimir Sitnikov
> Priority: Major
>
> Currently RelCrossType#isStruct returns false even though the default
> implementation in {{org.apache.calcite.rel.type.RelDataTypeImpl#isStruct}} is
> {{return fieldList != null}}
> That results in {{getFieldList}} throwing assertion error (because it asserts
> {{isStruct}}), however RelCrossType#getFieldNames works OK because it asserts
> {{fieldList != null}}
> I think it should be OK if we remove {{isStruct() { return false; } }}
> override and use {{isStruct}} assertion in both {{getFieldList}} and
> {{getFieldNames}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
