[
https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189838#comment-17189838
]
Liya Fan commented on CALCITE-4197:
-----------------------------------
[~julianhyde][~danny0405] Thanks for your feedback.
Your comments sound mostly reasonable to me.
I want to discuss this one: "Could we remove the arc labels? (0, 1)"
IMO, the arc labels contain important information. For example, given a Join,
it helps us easily identify which input is the left side, and which one is the
right side.
Please note that, GraphViz has an algorithm to make the graph representations
look compact, so it may paint the left input on the right and vice versa.
So can we keep the arc labels?
> Provide utility to visualize RelNode plans
> ------------------------------------------
>
> Key: CALCITE-4197
> URL: https://issues.apache.org/jira/browse/CALCITE-4197
> Project: Calcite
> Issue Type: New Feature
> Components: core
> Reporter: Liya Fan
> Assignee: Liya Fan
> Priority: Major
> Labels: pull-request-available
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png, screenshot-5.png
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> From time to time, we want to visualize the plan generated the optimizer as a
> DAG (Directed Acyclic Graph). This gives us an overview of the plan, and
> helps us to find problems with the plan quickly.
> A common way to visualize a DAG is to dump it in the {{dot}} format, and then
> display the DAG through GraphViz. Currently, we already have a utility to
> dump the Volcano planner in dot format. In this issue, we want to dump a
> RelNode plan (a RelNode DAG) in the dot format, which will help users to see
> their plans more clearly.
> The utility should have some options that allow users to specify the
> visuzalization details, for example:
> 1. the max length of a node description.
> 2. whether RelSubset/HepRelVertex should be displayed.
> 3. Nodes that should be highlighted.
> Could you please give some feedback?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
