[
https://issues.apache.org/jira/browse/CALCITE-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189881#comment-17189881
]
Vladimir Sitnikov commented on CALCITE-4215:
--------------------------------------------
{quote} But we can not rely on the IDE to keep good code quality{quote}
I think we can. I'm sure major IDEs can even share inspection configurations
via git, so we can configure that "null unboxing" would look like an error in
IDE.
In any case, "null unboxing" is relatively easy to detect with
checkerframework, and it does not result in false-positives. In other words, if
"get row count" method is annotated with {{@Nullable}}, then IDE produces a
warning, and checkerframework produces an error (~it takes 10min to verify full
{{:core}} sources, so it looks very promising).
> Ensure org.apache.calcite.schema.Statistic uses null vs emptyList
> appropriately
> -------------------------------------------------------------------------------
>
> Key: CALCITE-4215
> URL: https://issues.apache.org/jira/browse/CALCITE-4215
> Project: Calcite
> Issue Type: Sub-task
> Components: core
> Affects Versions: 1.25.0
> Reporter: Vladimir Sitnikov
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> null: statistic is *not* *known*
> emptyList: statistic is *known*, and the value is *empty* (e.g. no unique
> keys in the table)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
