[ 
https://issues.apache.org/jira/browse/CALCITE-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190356#comment-17190356
 ] 

Julian Hyde commented on CALCITE-4220:
--------------------------------------

Yes, I'm working on this. That's why I set status to 'in progress'. Thanks for 
the offer, though.

> In SqlToRelConverter, use RelBuilder for creating Aggregate
> -----------------------------------------------------------
>
>                 Key: CALCITE-4220
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4220
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>            Priority: Major
>
> In {{SqlToRelConverter}} use {{RelBuilder}} for creating {{Aggregate}}. 
> Currently we call LogicalAggregate.create directly, and that misses some 
> optimizations.
> Add config option {{RelBuilder.Config.skipAggOnUniqueKey()}} to disable the 
> optimization that we don't create an {{Aggregate}} if the input is already 
> unique on the GROUP BY key. Without it, some tests in 
> {{SqlToRelConverterTest}} become trivial.
> Also, that optimization is not valid if there are multiple group sets. 
> (Because we should output multiple rows, and Project only returns one.) So 
> disable it in that case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to