[
https://issues.apache.org/jira/browse/CALCITE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193075#comment-17193075
]
Laurent Goujon commented on CALCITE-4224:
-----------------------------------------
I'm not sure I see how much more convenient it is to switch one method with
another one. The only issue I experienced was that {{RelOptUtil}} is not always
in the source context and I need to use the fully qualify class name instead of
just the simple name.
On the other hand, having a public overridable method to go over the whole tree
seems too broad (does the method needs to access internal state? is it okay for
subclasses to override?). I guess I'm -0 on that, but would be okay for it to
exist as a static method in {{RelNode}}
> Add an method for RelNode to output its tree digest like RelOptUtil.toString
> ----------------------------------------------------------------------------
>
> Key: CALCITE-4224
> URL: https://issues.apache.org/jira/browse/CALCITE-4224
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Jiatao Tao
> Assignee: Jiatao Tao
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
