[ 
https://issues.apache.org/jira/browse/CALCITE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17193377#comment-17193377
 ] 

Jiatao Tao edited comment on CALCITE-4224 at 9/10/20, 5:14 AM:
---------------------------------------------------------------

Hi [~julianhyde],

`final` is not allowed after 
`default`([https://stackoverflow.com/questions/23453287/why-is-final-not-allowed-in-java-8-interface-methods).]

Are you OK with the code below?

org.apache.calcite.rel.RelNode#
{code:java}
/**
 * Returns a relational expression string of this {@code RelNode}.
 * The string returned is the same as 
 * {@link RelOptUtil#toString(org.apache.calcite.rel.RelNode)}.
 *
 * @return Relational expression string of this {@code RelNode}
 */
default String tree() {
  return RelOptUtil.toString(this);
} {code}


was (Author: aron.tao):
Hi [~julianhyde], `final` is not allowed after 
`default`([https://stackoverflow.com/questions/23453287/why-is-final-not-allowed-in-java-8-interface-methods).]

Are you OK with the code below?

org.apache.calcite.rel.RelNode#
{code:java}
/**
 * Returns a relational expression string of this {@code RelNode}.
 * The string returned is the same as 
 * {@link RelOptUtil#toString(org.apache.calcite.rel.RelNode)}.
 *
 * @return Relational expression string of this {@code RelNode}
 */
default String tree() {
  return RelOptUtil.toString(this);
} {code}

> Add an method for RelNode to output its tree digest like RelOptUtil.toString
> ----------------------------------------------------------------------------
>
>                 Key: CALCITE-4224
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4224
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jiatao Tao
>            Assignee: Jiatao Tao
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to