[ https://issues.apache.org/jira/browse/CALCITE-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197925#comment-17197925 ]
James Starr commented on CALCITE-4210: -------------------------------------- [~julianhyde] I reworked createJoinUsing and createJoinNatural to return conditions instead of the whole rel node, and now createJoinOnCondition returns a pair of the right node and the condition. I also made the inner class static. > Sub Query is 'On' clause does not correctly expand in SqlToRelConverter > ----------------------------------------------------------------------- > > Key: CALCITE-4210 > URL: https://issues.apache.org/jira/browse/CALCITE-4210 > Project: Calcite > Issue Type: Bug > Components: core > Reporter: James Starr > Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Aggregation is dropped during decorreleation. > {code:java} > SELECT "employee"."department_id", "employee"."salary" > FROM "department" > LEFT JOIN "employee" ON "employee"."salary" = ( > SELECT max("employee"."salary") > FROM "employee" > WHERE "employee"."department_id" = "department"."department_id" > ) > {code} > {code:java} > LogicalProject(department_id=[$9], salary=[$13]) > LogicalJoin(condition=[=($13, $0)], joinType=[left]) > LogicalTableScan(table=[[foodmart, department]]) > LogicalTableScan(table=[[foodmart, employee]]){code} > This may be related to CALCITE-4206. -- This message was sent by Atlassian Jira (v8.3.4#803005)