[ https://issues.apache.org/jira/browse/CALCITE-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Hyde updated CALCITE-4262: --------------------------------- Description: In {{SqlToRelConverter}}, use {{RelBuilder}} for creating all relational expressions. In CALCITE-4220 we switched to using {{RelBuilder}} for creating {{Aggregate}} (in some cases) but there are still calls to: * {{LogicalFilter.create}} and {{FilterFactory.createFilter}} * {{LogicalUnion.create}} * {{LogicalValues.createOneRow}} * {{MatchFactory.createMatch}} * {{LogicalTableScan.create}} * {{LogicalTableFunctionScan.create}} * {{LogicalCorrelate.create}} * {{LogicalUnion.create}} * {{LogicalIntersect.create}} * {{LogicalMinus.create}} * {{LogicalTableModify.create}} * {{JoinFactory.createJoin}} * {{AggregateCall.create}} * {{LogicalProject.create}} * {{LogicalSort.create}} The equivalent {{RelBuilder}} methods all exist. The biggest challenge is that the {{RelBuilder}} methods will do some optimizations (almost all improvements) that will cause plan changes. > In SqlToRelConverter, use RelBuilder for creating all relational expressions > ---------------------------------------------------------------------------- > > Key: CALCITE-4262 > URL: https://issues.apache.org/jira/browse/CALCITE-4262 > Project: Calcite > Issue Type: Bug > Reporter: Julian Hyde > Priority: Major > > In {{SqlToRelConverter}}, use {{RelBuilder}} for creating all relational > expressions. In CALCITE-4220 we switched to using {{RelBuilder}} for creating > {{Aggregate}} (in some cases) but there are still calls to: > * {{LogicalFilter.create}} and {{FilterFactory.createFilter}} > * {{LogicalUnion.create}} > * {{LogicalValues.createOneRow}} > * {{MatchFactory.createMatch}} > * {{LogicalTableScan.create}} > * {{LogicalTableFunctionScan.create}} > * {{LogicalCorrelate.create}} > * {{LogicalUnion.create}} > * {{LogicalIntersect.create}} > * {{LogicalMinus.create}} > * {{LogicalTableModify.create}} > * {{JoinFactory.createJoin}} > * {{AggregateCall.create}} > * {{LogicalProject.create}} > * {{LogicalSort.create}} > The equivalent {{RelBuilder}} methods all exist. The biggest challenge is > that the {{RelBuilder}} methods will do some optimizations (almost all > improvements) that will cause plan changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)