[ 
https://issues.apache.org/jira/browse/CALCITE-4240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200467#comment-17200467
 ] 

Danny Chen commented on CALCITE-4240:
-------------------------------------

I'm afraid not all the sql engines have the rule that `maxScale = maxScale / 
2`, we should add a check for the validity instead of modifying the value 
silently. And i'm inclined to fix the default max precision/scale for Calcite 
type system.

> SqlTypeUtil#getMaxPrecisionScaleDecimal will create decimal that has the same 
> precision and scale
> -------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4240
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4240
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Jiatao Tao
>            Assignee: Jiatao Tao
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to