[ 
https://issues.apache.org/jira/browse/CALCITE-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207491#comment-17207491
 ] 

Alessandro Solimando commented on CALCITE-4301:
-----------------------------------------------

If I am not wrong, tests were disabled only with JDK >8 (Travis Windows job 
using JDK8 was triggering them until few weeks ago).

Anyway now with "[CALCITE-4259] Support JDK 15 and Guava version 29.0-jre" they 
are disabled as Guava version is higher than 26.

I could either open a PR anyway (committer might downgrade Guava locally and 
test with JDK 8 as CI won't help, in case I have a 
[branch|https://github.com/asolimando/calcite/tree/CALCITE-4301] ready for 
that) or we keep it open waiting for the blockers to be solved and for tests to 
be runnable again (it might take some time as Cassandra 4 is needed).

What's best in your opinion?

> Unit test 'testCollectionsInnerValues()' for Cassandra adapter is wrong
> -----------------------------------------------------------------------
>
>                 Key: CALCITE-4301
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4301
>             Project: Calcite
>          Issue Type: Test
>          Components: cassandra-adapter
>    Affects Versions: 1.25.0
>            Reporter: Alessandro Solimando
>            Assignee: Alessandro Solimando
>            Priority: Minor
>
> The following unit test included in 
> `cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterDataTypesTest.java`
>  is wrong, as it applied _ITEM_ operator to a struct field _f_tuple_, instead 
> of the _DOT_ operator, returning _null_ instead of the correct _non-null_ 
> values. __ 
> {code:java}
>   @Test void testCollectionsInnerValues() {
>        CalciteAssert.that()
>            .with(DTCASSANDRA)
>            .query("select \"f_list\"[1], "
>                + "\"f_map\"['k1'], "
>                + "\"f_tuple\"['1'], "
>                + "\"f_tuple\"['2'], "
>                + "\"f_tuple\"['3']"
>                + " from \"test_collections\"")
>            .returns("EXPR$0=1"
>                + "; EXPR$1=v1"
>                + "; EXPR$2=3000000000"
>                + "; EXPR$3=30ff87"
>                + "; EXPR$4=2015-05-03 13:30:54.234");{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to