[
https://issues.apache.org/jira/browse/CALCITE-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vladimir Sitnikov updated CALCITE-4314:
---------------------------------------
Description:
Error-Prone would fail the build when it detects violations. The test code is
not verified.
The check takes 4-5 minutes.
One can execute the verification locally via ./gradlew -PenableErrorpone
-Pwerror=false classes
Calcite uses Werror by default to fail on javac warnings, so -Pwerror=false
allows Error-Prone to display all the warnings.
----
Most of the changes (35 commits in total, +5,779 −5,015) are for the following
checks:
Add missing @Override annotations
745 files changed, 4490 insertions(+), 4456 deletions(-)
Add missing default branches to switch statement
98 files changed, 691 insertions(+), 55 deletions(-)
Remove unused fields, methods, and variables
79 files changed, 104 insertions(+), 149 deletions(-)
was:[http://errorprone.info/] provides the ability to do static checks like
Spotbugs (CALCITE-1006).
> Enable Error Prone checking
> ---------------------------
>
> Key: CALCITE-4314
> URL: https://issues.apache.org/jira/browse/CALCITE-4314
> Project: Calcite
> Issue Type: Improvement
> Components: build
> Reporter: Vladimir Sitnikov
> Assignee: Vladimir Sitnikov
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.27.0
>
>
> Error-Prone would fail the build when it detects violations. The test code is
> not verified.
> The check takes 4-5 minutes.
> One can execute the verification locally via ./gradlew -PenableErrorpone
> -Pwerror=false classes
> Calcite uses Werror by default to fail on javac warnings, so -Pwerror=false
> allows Error-Prone to display all the warnings.
> ----
> Most of the changes (35 commits in total, +5,779 −5,015) are for the
> following checks:
> Add missing @Override annotations
> 745 files changed, 4490 insertions(+), 4456 deletions(-)
> Add missing default branches to switch statement
> 98 files changed, 691 insertions(+), 55 deletions(-)
> Remove unused fields, methods, and variables
> 79 files changed, 104 insertions(+), 149 deletions(-)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
