[ 
https://issues.apache.org/jira/browse/CALCITE-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210138#comment-17210138
 ] 

Vladimir Sitnikov commented on CALCITE-4319:
--------------------------------------------

[~FatLittle], [~hyuan], do you think this NPE is plausible?
Do you know what should be the proper way to handle null convention in 
TopDownRuleDriver?

> NPE in TopDownRuleDriver#convert when convention is not enabled
> ---------------------------------------------------------------
>
>                 Key: CALCITE-4319
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4319
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core
>            Reporter: Vladimir Sitnikov
>            Priority: Major
>
> {code:java}    VolcanoRuleMatch match = ruleQueue.popMatch(
>         Pair.of(rel,
>             m -> m.getRule() instanceof ConverterRule
>                 && 
> m.getRule().getOutTrait().satisfies(group.getTraitSet().getConvention())));
> {code}
> satisfies(null) fails with NPE
> see 
> https://github.com/apache/calcite/blob/532f903fe495d741053619c13a51537e57dcd619/core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java#L586



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to