[ 
https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222742#comment-17222742
 ] 

Liya Fan commented on CALCITE-4360:
-----------------------------------

[~Chunwei Lei] Thanks for the investigation. 

The process is a little tricky. However, I wish we could add some comments to 
the related code, so the code reader will no longer be confused. 

> Apply SubstitutionRule first in top-down driven rule apply
> ----------------------------------------------------------
>
>                 Key: CALCITE-4360
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4360
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Chunwei Lei
>            Assignee: Chunwei Lei
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2020-10-27-21-55-55-155.png
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> In the current implementation, TopDownRuleQueue adds substitute rules in the 
> end wrongly. The SubstitutionRule should be executed first.
> !image-2020-10-27-21-55-55-155.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to