[
https://issues.apache.org/jira/browse/CALCITE-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252010#comment-17252010
]
Julian Hyde commented on CALCITE-4436:
--------------------------------------
Nice work, [~asolimando]. I like how you systematically removed the flags that
were added in
[3f0353ce|https://github.com/apache/calcite/commits/3f0353cecfbdfa3b85e6a4fe11946df912ebd2b1].
> Use the fields order from the struct type for 'ITEM(STRUCT, INDEX)' access
> --------------------------------------------------------------------------
>
> Key: CALCITE-4436
> URL: https://issues.apache.org/jira/browse/CALCITE-4436
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.27.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.27.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The index-based access via the "ITEM" operator for operands of row/struct
> type is currently experimental and disabled by default (introduced in
> CALCITE-4354).
> Its implementation uses the fields order from `getDeclaredFields()`, a
> JVM-specific feature, this might lead to silent data corruption (see
> [PR-2230|https://github.com/apache/calcite/pull/2230]).
> The aim of the ticket is to improve the feature by relying on the safer
> fields order
> from the struct field type itself (_i.e._, `relType.getFields()[index]`) so
> that we can enable it by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
