[
https://issues.apache.org/jira/browse/CALCITE-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253122#comment-17253122
]
Julian Hyde commented on CALCITE-4423:
--------------------------------------
Well, there are currently no tests. This speaks to the mind set "it works for
Drill, so it must be OK".
This can be committed, but it needs to come from the mindset that you are
building a feature, not the mindset "let me drill a hole so that it works for
me".
If you simply exposed a collection containing the Config of each JDBC rule,
then it would work for your purposes (you you use stream().map() to instantiate
each rule with your own trait) but it would also be useful for other people
with different requirements.
> Provide the ability to specify incoming trait in JdbcRules
> ----------------------------------------------------------
>
> Key: CALCITE-4423
> URL: https://issues.apache.org/jira/browse/CALCITE-4423
> Project: Calcite
> Issue Type: Improvement
> Affects Versions: 1.26.0
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> For the case of multiple planning phases, it becomes not enough to use JDBC
> rules that accept rel nodes with {{Convention.NONE}} {{RelTrait}}.
> It would be handly to provide the possibility to specify desired
> {{RelTrait}}, for example, update constructors of {{JdbcConverterRule}}
> successors and provide additional method:
> {{JdbcRules.rules(RelTrait in, JdbcConvention out, RelBuilderFactory
> relBuilderFactory)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
