[
https://issues.apache.org/jira/browse/CALCITE-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258243#comment-17258243
]
Ruben Q L commented on CALCITE-4188:
------------------------------------
Sorry I am arriving a bit late to this discussion.
I am not familiar with JdbcToEnumerableConverter, but I am familiar with
EnumerableBatchNestedLoopJoin.
I am a bit surprised seeing correlated variables implemented as "special"
dynamic parameters (I am not saying that this is wrong). IMO, we can see
EnumerableBatchNestedLoopJoin as a generalization of EnumerableCorrelate
(correlate is just kind of a batch nested loop with {{batchSize=1}}). How is
EnumerableCorrelate currently implemented in JdbcToEnumerableConverter? (I
assume it does not use dynamic parameters). Couldn't
EnumerableBatchNestedLoopJoin somehow reuse the EnumerableCorrelate logic in
JdbcToEnumerableConverter?
> support EnumerableBatchNestedLoopJoin in JdbcToEnumerableConverter implement
> ----------------------------------------------------------------------------
>
> Key: CALCITE-4188
> URL: https://issues.apache.org/jira/browse/CALCITE-4188
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.25.0
> Reporter: JIasen Sheng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> support EnumerableBatchNestedLoopJoin in JdbcToEnumerableConverter implement
> function
> ENUMERABLE_BATCH_NESTED_LOOP_JOIN_RULE make correlate RexNode,
> when implementing,
> [https://github.com/apache/calcite/blob/eab043f4ef43112c16a9f6708e6c53a15b1cfbe0/core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java#L675]
> will throw null Exception
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
