[ 
https://issues.apache.org/jira/browse/CALCITE-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260049#comment-17260049
 ] 

Julian Hyde commented on CALCITE-4443:
--------------------------------------

[~ostumpf], Thanks for making changes. I have reviewed your change, and it 
looks good.

I did some further refactoring, to make the configuration depend only on the 
library, and not on the conformance. This makes it consistent with library 
functions. (This is our first library operator, i.e. with non-function syntax, 
but it makes sense to be consistent with library functions.)

I also changed the field {{ignoreCase}} to {{caseSensitive}}, to be consistent 
with {{SqlPosixRegexOperator}}.

Please review my additional commits in 
[julianhyde/4443-ilike|https://github.com/julianhyde/calcite/tree/4443-ilike].

> Add support for the ILIKE operator to core
> ------------------------------------------
>
>                 Key: CALCITE-4443
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4443
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Ondřej Štumpf
>            Assignee: Julian Hyde
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.27.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Extend the list of supported relational operators in SqlStdOperatorTable with 
> ILIKE. The new ILIKE keyword should be unreserved and behave exactly like 
> LIKE, but without case-sensitivity.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to