[ 
https://issues.apache.org/jira/browse/CALCITE-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269638#comment-17269638
 ] 

Julian Hyde commented on CALCITE-4474:
--------------------------------------

Move the test to SqlAdvisorTest? That is how SqlSimpleParser is tested at 
present.

> SqlSimpleParser inner Tokenizer ignore comment in some special case
> -------------------------------------------------------------------
>
>                 Key: CALCITE-4474
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4474
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.26.0
>            Reporter: wangjie
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.26.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> the SqlSimpleParser#simplifySql function can filter comments
> but when `--` follow by variable, this comment will not be filter. In fact, 
> it should be filtered
> you can see reproduce-demo inĀ 
> [https://github.com/wangjie-fourth/calcite-reproduce]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to