[
https://issues.apache.org/jira/browse/CALCITE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289785#comment-17289785
]
Ruben Q L commented on CALCITE-4510:
------------------------------------
Could we see the issue in a unit test?
I agree the current code is not very elegant, but it would seem it "checks the
type string suffix with an 8-character string", i.e. it checks {{endsWith("NOT
NULL")}}
And then "it trims the last 9 characters from the end of the string", just
because it also trims the white-space that precedes that string: " NOT NULL";
e.g. for a digest "XYZ NOT NULL" we end up with "XYZ"; which seems fine. Is
there an issue in that? Am I missing something?
> Weird digests for literals with some user defined types
> -------------------------------------------------------
>
> Key: CALCITE-4510
> URL: https://issues.apache.org/jira/browse/CALCITE-4510
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Liya Fan
> Assignee: Liya Fan
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We find weird literals for some user defined non-nullable types. Some
> investigation shows that the problem lies in the {{RexLiteral#toJavaString}}
> method.
> In particular, it checks the type string suffix with an 8-character string:
> {noformat}
> if (!fullTypeString.endsWith("NOT NULL")) {
> {noformat}
> However, it trims the last 9 characters from the end of the string:
> {noformat}
> sb.append(fullTypeString, 0, fullTypeString.length() - 9);
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
