[ 
https://issues.apache.org/jira/browse/CALCITE-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Hyde resolved CALCITE-4514.
----------------------------------
    Fix Version/s: 1.27.0
       Resolution: Fixed

Fixed in 
[cd34e5da|https://github.com/apache/calcite/commit/cd34e5dacfa43e3442029a05085f669377863033];
 thanks for the PR, [~botong]!

(I choose to keep my control flow rather than yours. I believe that both have 
the same effect, but my control flow handles the cases of single parents, 
cyclic parents, and non-parents separately, and is therefore clearer.)

> [CALCITE-4514] Fine tune the merge order of two RelSets
> -------------------------------------------------------
>
>                 Key: CALCITE-4514
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4514
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Botong Huang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.27.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> When merging two relsets, we have two preferences: 
> 1. Merge parent relset into child relset
> 2. Merge newer relset into older relset
> Currently, when the two relsets are parent set of each other, we randomly 
> pick a merge order without checking the second condition above. For 
> performance reasons, we should, to avoid unnecessary churn. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to