[ 
https://issues.apache.org/jira/browse/CALCITE-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302868#comment-17302868
 ] 

Julian Hyde commented on CALCITE-4538:
--------------------------------------

This what I call a "drill-a-hole" change, and I don't like such changes. By 
making the constructor public, we give up the ability to refactor the class in 
future.

I would rather talk about Beam's use case and how we can accommodate that use 
case.

> Make CalcRelSplitter constructor public.
> ----------------------------------------
>
>                 Key: CALCITE-4538
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4538
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Kyle Weaver
>            Priority: Major
>
> CalcRelSplitter is a public class, but its constructor is package-private. 
> We'd like to implement this class in Beam, which would require making the 
> constructor public.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to