[
https://issues.apache.org/jira/browse/CALCITE-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302984#comment-17302984
]
Julian Hyde commented on CALCITE-4538:
--------------------------------------
If you just intend to add the keyword 'public', and add no supporting
documentation or tests, that's what I'd call 'drilling a hole'. In contrast, a
'fully public API' is documented and tested in such a way that others can
follow the same path that you have. I would support the latter, not the former.
> Make CalcRelSplitter API public.
> --------------------------------
>
> Key: CALCITE-4538
> URL: https://issues.apache.org/jira/browse/CALCITE-4538
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Kyle Weaver
> Priority: Major
>
> CalcRelSplitter is a public class, but its constructor is package-private.
> We'd like to implement this class in Beam, which would require making the
> constructor (and possibly other pieces) public.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
