[
https://issues.apache.org/jira/browse/CALCITE-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343407#comment-17343407
]
Julian Hyde commented on CALCITE-4605:
--------------------------------------
I believe you are referring to [UnregisteredDriver.java line
134|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/UnregisteredDriver.java#L134].
This code might be used from a sub-class that has overridden the {{acceptsURL}}
method. The {{assert}} could fire if the author of the sub-class has really
messed up the implementation of that method.
I claim the purpose of an {{assert}} is to alert developers to their own stupid
mistakes (not to alert users) and if so, that {{assert}} still has a purpose.
> Unnecessary Prefix assert in UnregisteredDriver#connect
> -------------------------------------------------------
>
> Key: CALCITE-4605
> URL: https://issues.apache.org/jira/browse/CALCITE-4605
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Xianghu Wang
> Priority: Major
>
> The URL prefix has already been verified in
> {{org.apache.calcite.avatica.UnregisteredDriver#acceptsURL}}, so the
> following assertion is unnecessary.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
