[ 
https://issues.apache.org/jira/browse/CALCITE-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343705#comment-17343705
 ] 

Julian Hyde commented on CALCITE-4576:
--------------------------------------

Now also fixed in Calcite. The LICENSE file was fixed in 
[28d156f7|https://github.com/apache/calcite/commit/28d156f7903365afb69416fa11e2d3252a4c68b8],
 and now  
[f7e029fa|https://github.com/apache/calcite/commit/f7e029fa3548d015f6a9ac3bc5da2a9af6357db6]
 has updated the instructions for the release manager.

> Release process should not overwrite LICENSE file
> -------------------------------------------------
>
>                 Key: CALCITE-4576
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4576
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica, build
>    Affects Versions: avatica-1.17.0, 1.26.0
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: avatica-1.18.0, 1.27.0
>
>
> The release process should not generate a source distribution whose 
> {{LICENSE}} file has different contents from the {{LICENSE}} file stored in 
> Git.
> Rationale: Source distributions should be a mirror of the contents of Git at 
> the time of the release. (Possibly a few files are omitted -- see 
> CALCITE-4575 for example -- but files should not be generated/compiled.) 
> Users expect that the LICENSE file they see in Git is the same as the LICENSE 
> file in the source distribution.
> One possible implementation of this is as follows. The release process should 
> not overwrite the {{LICENSE}} file when generating the source distribution. 
> It should generate a {{LICENSE}} file (possibly from a {{LICENSE.template}} 
> file), check that the one in source control is identical, and fail if it is 
> not.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to