[
https://issues.apache.org/jira/browse/CALCITE-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359505#comment-17359505
]
Julian Hyde commented on CALCITE-4630:
--------------------------------------
[~dmsysolyatin], The PR seems to be good progress. Have you identified which
component seems to be making the mistake? The fact that you have added a test
case to {{SqlToRelConverterTest}} suggests that you think that it is
{{SqlToRelConverter}}.
I am wary of using {{RelVisitor}}. Planner rules act locally - e.g. a rule
might push a Filter through a Project but does not need to worry whether the
input to the Project is a Union or a Sort with limit or whatever. Acting
locally has many benefits, including performance. We should use {{RelVisitor}}
only when the problem must be solved on the global tree. And I'm not convinced
of that yet.
> Wrong logical plan for INNER JOIN with subquery
> -----------------------------------------------
>
> Key: CALCITE-4630
> URL: https://issues.apache.org/jira/browse/CALCITE-4630
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.27.0
> Reporter: Dmitry Sysolyatin
> Assignee: Dmitry Sysolyatin
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I tried to execute the following query:
> {code:sql}
> SELECT
> d.name,
> d.timestamp_ns
> FROM trucks t
> INNER JOIN LATERAL (
> SELECT
> name, timestamp_ns, fuel_state
> FROM
> trucks_diagnostics
> WHERE
> trucks_diagnostics.name = t.name
> ORDER BY timestamp_ns DESC
> LIMIT 1) d ON true WHERE t.fleet = 'South' AND d.fuel_state < 0.1
> {code}
> calcite generates me the following logical plan:
> {code:java}
> LogicalProject(name=[$8], timestamp_ns=[$9])
> LogicalCorrelate(correlation=[$cor0], joinType=[inner],
> requiredColumns=[{4}])
> LogicalFilter(condition=[=(CAST($6):VARCHAR, 'South')])
> DataTableScan
> LogicalFilter(condition=[<($2, 0.1:DECIMAL(2, 1))])
> LogicalSort(sort0=[$1], dir0=[DESC], fetch=[1])
> LogicalProject(name=[$4], timestamp_ns=[$0], fuel_state=[$1])
> LogicalFilter(condition=[=(CAST($4):VARCHAR,
> CAST($cor0.name):VARCHAR)])
> DataTableScan
> {code}
> But `LogicalFilter(condition=[<($2, 0.1:DECIMAL(2, 1))])` should not be
> inside LogicalCorrelate . It should be upper than LogicalCorrelate
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
