[
https://issues.apache.org/jira/browse/CALCITE-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360394#comment-17360394
]
Yingyu commented on CALCITE-4634:
---------------------------------
The PR for the 1st part of the change is available for review:
https://github.com/apache/calcite/pull/2432
This PR is for adding the variation of `config.removeAllConstants()`. When this
config option is true the rule will force removing all constant keys. A filter
will be added if GROUP BY keys become empty to ensure `Aggregate([])` returns 0
row when its input is empty.
> Improve AggregateProjectPullUpConstantsRule to remove all constant keys
> -----------------------------------------------------------------------
>
> Key: CALCITE-4634
> URL: https://issues.apache.org/jira/browse/CALCITE-4634
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.16.0
> Reporter: Yingyu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Optimizer rule *AggregateProjectPullUpConstantsRule* removes constant keys
> from an Aggregate. However, this rules never removes the last column, because
> Aggregate([]) returns 1 row even if its input is empty.
> An enhancement could be done to AggregateProjectPullUpConstantsRule so that
> it removes all constant keys:
> - Remove all constant keys from an Aggregate
> - (Only)When no key is left from previous step (Aggregate becomes
> Aggregate([])), add a filter to the Aggregate([]) so that it returns empty
> dataset if its input is empty.
> E.g.
> {noformat}
> SELECT 'abc' FROM table_name GROUP BY ('abc')
> {noformat}
> will be translated to:
> {noformat}
> SELECT 'abc' FROM table_name GROUP BY () having count(*)>0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
